[GEN-1588] Avoid 0 sats/vb#529
Open
imclvr wants to merge 1 commit into
Open
Conversation
Jossec101
reviewed
Jul 2, 2026
Jossec101
reviewed
Jul 6, 2026
| if (recommendedFeeRate == null) | ||
| { | ||
| _logger.LogWarning("Error getting recommended fee rate for type {feeType}, using 0", mempoolFeesType); | ||
| feeRate = 0; |
Contributor
There was a problem hiding this comment.
If mempool is down use 1 (?)
Contributor
Author
There was a problem hiding this comment.
1, or 0.1? 🤔
1 => More money wasted, faster mining.
0.1 => Conservative, slower mining.
Contributor
There was a problem hiding this comment.
mm this kind of breaks this code inside GenerateTemplatePSBT
//We get the mempool.space recommended fees, the custom or use the bitcoin core (nbxplorer) one if not available
var feerate = await _nbXplorerService.GetFeesByType(walletWithdrawalRequest.MempoolRecommendedFeesType)
?? walletWithdrawalRequest.CustomFeeRate
?? (await LightningHelper.GetFeeRateResult(network, _nbXplorerService)).FeeRate
.SatoshiPerByte;if the mempool is not working, then we default to LightningHelper.GetFeeRateResult as a backup
Contributor
Author
There was a problem hiding this comment.
but @RodriFS , for what I saw, GetFeeRateResult relies on Mempool for non reg-test, so in this particular case (and rare) where mempool service is not up, it will call it again 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.